remove remaining usage of action helper (#723)

.template-lintrc.js

@@ -3,7 +3,6 @@
 module.exports = {
   extends: 'recommended',
   rules: {
-    'no-action': false,
     'no-implicit-this': {
       allow: ['scroll-first-invalid-element-into-view-port'],
     },

app/controllers/poll/participation.js

@@ -70,4 +70,9 @@ export default class PollParticipationController extends Controller {
       queryParams: { encryptionKey },
     });
   }
+
+  @action
+  resetSavingStatus() {
+    this.savingFailed = false;
+  }
 }

app/templates/create/meta.hbs

@@ -38,7 +38,7 @@
         <NextButton />
       </div>
       <div class="col-6 col-md-4 order-1 text-right">
-        <BackButton @onClick={{action "previousPage"}} />
+        <BackButton @onClick={{this.previousPage}} />
       </div>
     </div>
   </BsForm>

app/templates/create/settings.hbs

@@ -18,7 +18,7 @@
       <select
         id={{el.id}}
         class="custom-select"
-        {{on "change" (action el.setValue value="target.value")}}
+        {{on "change" (pick "target.value" el.setValue)}}
         {{autofocus}}
       >
         {{#each this.answerTypes as |answerType|}}
@@ -75,7 +75,7 @@
         />
       </div>
       <div class="col-6 col-md-4 order-1 text-right">
-        <BackButton @onClick={{action "previousPage"}} />
+        <BackButton @onClick={{this.previousPage}} />
       </div>
     </div>
   </BsForm>

app/templates/poll/participation.hbs

@@ -131,7 +131,7 @@
 </div>
 
 <BsModal
-  @onHidden={{action (mut this.savingFailed) false}}
+  @onHidden={{this.resetSavingStatus}}
   @onSubmit={{this.save}}
   @open={{this.savingFailed}}
   data-test-modal="saving-failed"