Commit graph

13 commits

Author SHA1 Message Date
Jeldrik Hanschke
77afc0d9fa
remove implicit this usage in templates (#352)
This refactors references to values in templates from `{{foo}}` to either `{{this.foo}}` if it's a property of backing JavaScript class or `{{@foo}}` if it's passed in on invocation.

You could find more details on this change in Ember docs:
- [required `this` in templates](https://guides.emberjs.com/release/upgrading/current-edition/templates/#toc_required-this-in-templates)
- [named arguments](https://guides.emberjs.com/release/upgrading/current-edition/templates/#toc_named-arguments)

While doing this I noticed that `<PollEvaluationSummaryOption>` component could be easily refactored to a template-only component. Done it as part of this pull request even so it's technically not related.
2020-01-18 12:17:06 +01:00
Jeldrik Hanschke
c9482786c1
refactor to native ECMAScript classes (#344)
Replaces Ember's old object model by native ECMAScript classes. Mostly automated with ember-native-class-codemod.
2020-01-18 10:13:50 +01:00
Jeldrik Hanschke
b421d19601
refactor step management and do not allow going forward with invalid state (#263)
Also removes an observer that causes a "You modified 'disabled' twice in a single render" and executes the logic in the next run loop to prevent that error. That's not ideal but it's not time for a major refactoring of that part.
2019-10-29 08:42:00 +01:00
Jeldrik Hanschke
6e26789b8b improve positioning of validation feedback
Also refactors the template to use Octance features.
2019-10-28 13:18:53 +01:00
sappor0
c23ba1f6fb Using bootstrap 4 and related UI refresh (#205)
Changes at a glance:

- Switch from BS3 to BS4
- Polishing of some UI elements (low-hanging fruit for UX)
- Mobile-friendly layout.
2019-06-07 11:22:13 +02:00
Jeldrik Hanschke
bcd4bc7ac6 upgrade to ember 3.4 2018-12-31 10:17:03 +01:00
jelhan
9c4bd9e669
upgrade ember-bootstrap and ember-bootstrap-cp-validations to latest versions (#146)
Ember Bootstrap has changed a lot since the very outdated pre 1.0 release
which was used here. Changes are mostly about using composable components
and closure actions.

Also replaces PhantomJS with Chrome in CI cause PhantomJS is also very
outdated and causing test failure not related to any real world issues.
Ember CLI has replaced PhantomJS with Chrome in v2.15.1, which is the
upfollowing minor release to the version currently used.
2018-10-28 22:54:14 +01:00
jelhan
545f3b0664 autofocus first form element
currently not working for date selection (calendar) since this one did not
support keyboard navigation

part of #94
2016-08-26 00:10:22 +02:00
jelhan
4a31aaa616 use ember-bootstrap in create/options
ToDo:
Label validation state should not be bound to validation state of first element (option)
but to validation state of all elements. If any element has an error label validation state
should be error. Only if all elements are fine, label validation state should also be fine.
2016-06-06 01:19:24 +02:00
jelhan
70f7879ee7 Fixes #55 2016-05-20 21:49:29 +02:00
jelhan
f3426b2a7d support creating polls with only one option
There might be use cases and it simplifies validation a lot.

Also fixes this missing translation message mentioned in #84:
> /create/options-datetime: There isn't any validation error shown when validation fails due to not enough times.
2016-04-15 11:21:26 +02:00
jelhan
0e4fd114cb some improvement on validations 2016-02-09 01:16:18 +01:00
jelhan
ce2a8c8e1f done most things except date with times
also validation messages are missing
2016-01-19 04:56:51 +01:00