Commit graph

475 commits

Author SHA1 Message Date
Jeldrik Hanschke
b421d19601
refactor step management and do not allow going forward with invalid state (#263)
Also removes an observer that causes a "You modified 'disabled' twice in a single render" and executes the logic in the next run loop to prevent that error. That's not ideal but it's not time for a major refactoring of that part.
2019-10-29 08:42:00 +01:00
Jeldrik Hanschke
67caaad803
upgrade Ember CLI to 3.13 and Ember Source + Ember Data to 3.12 (#264)
* upgrade Ember CLI to 3.13 and Ember Source + Ember Data to 3.12

Ember Source upgrade to 3.13 is blocked by Ember CP Validations,
which does not support Ember Source 3.13 yet.

Ember Data upgrade to 3.13 is blocked by Ember Data Model Fragments,
which does not support Ember Data 3.13 yet.

Also removes autofocus mixin and inlines the code as mixins are
considered an antipattern in latest Ember versions.

Removes some left overs in `"resolutions"` key. But that shouldn't have a real impact.
2019-10-29 08:02:50 +01:00
Jeldrik Hanschke
6e26789b8b improve positioning of validation feedback
Also refactors the template to use Octance features.
2019-10-28 13:18:53 +01:00
Jeldrik Hanschke
56643d08eb fix missing validation feedback for input groups
Ember Boostrap adds `.d-block` class to validation feedback in order to
make it visible for input-group in which the `.invalid-feedback` is not
a silbing of `.form-control`.

This fixes the invisble validation feedback on /create/options (poll type:
answer a question) and /create/options-datetime (poll type: find a date).
2019-10-28 13:18:53 +01:00
Jeldrik Hanschke
6b0bb68919
fix invisible validation error message for date selection (#257) 2019-10-20 12:43:27 +02:00
jelhan
2ed888711b
show flash message if creating poll failed (#222) 2019-06-15 00:50:55 +02:00
jelhan
07da863520
fix typo resulting in missing translation strings (#224) 2019-06-15 00:04:32 +02:00
jelhan
65063c71ce
validation error is flashing up for name input while saving participation (#219) 2019-06-14 23:58:53 +02:00
jelhan
7688d468e4
improve form buttons (#211)
* Adds a loading spinner to form buttons as long as submission is pending.
* Does some refactoring of form navigation buttons.
* Updates expected bundle size.
2019-06-12 09:07:48 +02:00
sappor0
32e5971aba Fixed some typographic issues and typos and stylistic issues with the en localisation (#215)
* Fixed some typos/stylistic issues with the english localisation strings
* typographically correct ellipsis
* typographically correct apostrophe
* typographically correct em dash
2019-06-10 19:51:30 +02:00
sappor0
c23ba1f6fb Using bootstrap 4 and related UI refresh (#205)
Changes at a glance:

- Switch from BS3 to BS4
- Polishing of some UI elements (low-hanging fruit for UX)
- Mobile-friendly layout.
2019-06-07 11:22:13 +02:00
jelhan
08f2a81ac1
Drop jQuery (#196)
Drops ember-radio-buttons addon and uses a plain input element instead. ember-radio-buttons doesn't seem to be maintained anymore and required jQuery. Also plain input element seems to be much easier to maintain.

Replaces ember-ajax by ember-fetch as ember-ajax is build on top of jQuery.ajax().

This reduces the bundle size by 25 KB (JavaScript) after gzip. Updating the size limit accordingly.
2019-05-22 12:29:29 +02:00
jelhan
17cfb4ab6d
Meaningful error pages (#177)
Adds meaningful error pages if
- poll does not exist
- encryption key is wrong.
2019-04-23 17:37:42 +02:00
jelhan
bb160cc503
refactor participants table (#164)
- Drops floatthead and additional scrollbar
- Makes header and first column sticky
- Refactors code for readability

Sticky header is only working in Firefox. Chrome and Edge does not support `position: sticky` for `<thead>`. Haven't tested Safari.
2019-04-20 23:29:59 +02:00
jelhan
95d53baae9
refactor: remove route actions (#166) 2019-02-24 00:32:37 +01:00
Jeldrik Hanschke
06a92b947f refactor: replace bootstrap-datepicker by ember-power-calendar
Also renders two linked calendars if there is enough space.

Closes #143
2019-01-20 17:08:16 +01:00
Jeldrik Hanschke
96f1990542 fix: label should reflect validation state of all times of a day 2019-01-03 00:46:36 +01:00
Jeldrik Hanschke
cf9efe993b refactor: replace LESS by SASS 2019-01-02 23:48:48 +01:00
Jeldrik Hanschke
af4fe70f72 refactor: drop ember-simple-select 2019-01-02 23:48:36 +01:00
Jeldrik Hanschke
3091f9ac5e deps: upgrade ember-page-title
Current page title is put before generic one, e.g. "Create a poll | Croodle"
instead of "Croodle | Create a poll". This was an upstream change with
could reasoning. Have a look here:
https://github.com/adopted-ember-addons/ember-page-title/releases/tag/5.0.0

Version 4.0.0 required the `{{head-layout}}` component in application's
template:
https://github.com/adopted-ember-addons/ember-page-title/releases/tag/4.0.0
2018-12-31 14:12:21 +01:00
Jeldrik Hanschke
3330151156 refactor: drop unnecessary dynamic component usage 2018-12-31 12:09:23 +01:00
Jeldrik Hanschke
174b6d493c refactor create/settings to avoid observer
This also fix a bug if user creates more than one croodle without reloading window
in between. In that case a data fragment is reused which throws.

It's also the first step in dropping {{simple-select}} which is very outdated.
2018-12-31 12:09:17 +01:00
Jeldrik Hanschke
bcd4bc7ac6 upgrade to ember 3.4 2018-12-31 10:17:03 +01:00
Jeldrik Hanschke
b7e63ed83b refactor: replace ember-object-at-helper by ember-composable-helpers 2018-12-30 10:06:49 +01:00
Jeldrik Hanschke
71d303174e refactor: drop ember-array-computed-macros 2018-12-30 01:04:33 +01:00
jelhan
b8af8ea121
Merge pull request #148 from jelhan/fix-translation-of-validation-errors
fix: validation errors should be translated
2018-12-29 22:09:22 +01:00
Jeldrik Hanschke
8f591e2978 refactor: use version provided in config in favor of ember-cli-build-info 2018-12-29 22:09:14 +01:00
Jeldrik Hanschke
b8d4087aaf fix: validation errors should be translated
https://github.com/jasonmit/ember-i18n-cp-validations/tree/v3.1.0#breaking-changes-between-2x-and-3x-for-ember-i18n-cp-validations
2018-12-29 21:23:29 +01:00
Jeldrik Hanschke
11265cb82d deps: upgrade ember to 2.18 2018-12-29 20:23:19 +01:00
Jeldrik Hanschke
78ddf381c1 deps: upgrade ember-cli-bootstrap-datepicker
Drops another bower dependency. 🎉
2018-12-29 20:23:19 +01:00
Jeldrik Hanschke
6592102837 deps: upgrade ember-cp-validations to 3.x 2018-12-29 20:23:19 +01:00
jelhan
9c4bd9e669
upgrade ember-bootstrap and ember-bootstrap-cp-validations to latest versions (#146)
Ember Bootstrap has changed a lot since the very outdated pre 1.0 release
which was used here. Changes are mostly about using composable components
and closure actions.

Also replaces PhantomJS with Chrome in CI cause PhantomJS is also very
outdated and causing test failure not related to any real world issues.
Ember CLI has replaced PhantomJS with Chrome in v2.15.1, which is the
upfollowing minor release to the version currently used.
2018-10-28 22:54:14 +01:00
jelhan
fe826666ba Fixes "TypeError: attempted to assign to readonly property" in Safari 10.1 2017-08-31 14:24:49 +02:00
jelhan
ee8c64e031 show expiration date and warn if poll will expire in next days (#140)
Closes #121
2017-08-26 02:14:09 +02:00
jelhan
ee6728314a replace jstimezonedetect by moment.tz.guess() (#139)
Closes #118
2017-08-26 01:54:41 +02:00
jelhan
fc342b6c05 Fix: poll creation time is not displayed as formatted
Also fixes #122
2017-08-13 20:32:23 +02:00
jelhan
64a9dea5e7 refactor dates handling (#137)
* Remove dates ArrayProxy.
* Use moment template helpers.
* Pass timezone and locale directly to moment template helper to avoid issues.
2017-08-11 16:39:36 +02:00
jelhan
e99a2f13b8 Fix: chart options are overriden by poll options
Bug introduced by 1df562b352.
2017-08-03 16:44:38 +02:00
jelhan
1df562b352 refactor {{poll-evaluation-chart}} and {{poll-evaluation-participants-table}} interfaces to make them less complex 2017-08-01 09:48:48 +02:00
jelhan
96ec32aa3e Fix: ember-i18n does not provide a default locale configuration for catalan 2017-08-01 09:48:48 +02:00
jelhan
53a34fcc2f Fixes DEPRECATION: Importing from the model-fragments module is deprecated.
Instead import from `ember-data-model-fragments
2017-08-01 09:48:48 +02:00
jelhan
632c36eb12 updates dependencies and fixes property modified twice in a single render deprecations 2017-08-01 09:48:48 +02:00
jorge_SD
b517f0dee2 improve spanish translations 2017-07-29 15:16:56 +02:00
jelhan
13598fbe1b include catalan and italian locales for moment and bootstrap-datepicker 2017-07-28 10:52:22 +02:00
jorge_SD
1b815f0ee9 add italian and catalan translations; improve english translations 2017-07-28 10:40:22 +02:00
jelhan
364147f4b6 fix build issue by updating ember-moment 2017-07-25 17:17:39 +02:00
heavygale
9f05db9b2e Small tweaks for the german translation 2017-07-04 10:48:35 +02:00
jelhan
495d56c6ea language selct should allways be inline
`.form-inline` only applies to forms within viewports that are at least 768px wide.
2017-02-09 17:34:05 +01:00
jelhan
b5b547fce6 Fix: assets should be relative to index.html to support installation in subdirectories 2016-12-25 23:01:22 +01:00
jelhan
387e6adcdc improve detection of language prefered by user 2016-12-03 20:44:40 +01:00
jelhan
d76783c9cf refactor form navigation to use a component 2016-09-23 19:39:31 +02:00
jelhan
fa0ac48500 Readd spanish translation
thanks to @rugk
2016-09-20 11:50:04 +02:00
jelhan
ae0ad7bd42 Import sjcl by newly added Anonymous AMD Support
Fixes: `invalid aes key size` error in sjcl 1.0.5 and 1.0.6.

https://github.com/ember-cli/ember-cli/pull/5976
2016-09-20 02:01:33 +02:00
jelhan
fd0d7ffd39 update ember to 2.8 and ember-cli to 2.9.0-beta.1 2016-09-20 02:01:26 +02:00
jelhan
17b7f81dea UX: next and back buttons in create wizzard in xs and sm 2016-09-18 20:44:22 +02:00
jelhan
ed87a86c2c Fixes #115 2016-09-18 20:16:17 +02:00
rugk
e97c666458
Improve CSP header & add Referrer-Policy 2016-09-02 21:35:55 +02:00
jelhan
d6f7bb761c Fixed some typos
Thanks to @aehm03 for reporting via twitter:
https://twitter.com/aehm03/status/770918866658754560
2016-08-31 12:12:37 +02:00
jelhan
d5705b2c3b Fix: participation table header should not overflow container
Was introduced by this breaking change in jquery.floatThead:
3973eb523a
2016-08-30 11:10:05 +02:00
jelhan
9b221e7861 add a test for saving a new poll fails due to server 2016-08-26 19:04:50 +02:00
jelhan
545f3b0664 autofocus first form element
currently not working for date selection (calendar) since this one did not
support keyboard navigation

part of #94
2016-08-26 00:10:22 +02:00
jelhan
e735587c93 update floatThead and drop CSP unsafe-inline requirement
Closes #90
2016-08-23 11:43:58 +02:00
jelhan
94b4dc6f82 use localStorage instead of cookie to save locale setting
there is no need to tell the server which locale is prefered by client
2016-08-21 14:31:39 +02:00
jelhan
d8db29ecd9 adds back button to create wizard
Part of #76
2016-08-21 00:38:44 +02:00
jelhan
9a33e08ac4 browser should not mess around with our validation logic 2016-08-20 23:41:27 +02:00
jelhan
17d4a3feda save button should have suitable text 2016-08-20 23:35:54 +02:00
jelhan
8441c92295 use poll title as page title
Part of #76
2016-08-20 23:28:39 +02:00
jelhan
afb06e4f12 Fix: novalidate option of {{bs-form}} should be true (and not string 'true')
This had been fixed in ember-bootstrap 0.9.0
2016-08-20 22:59:50 +02:00
jelhan
8d9278a9ee show validation immediately after change for select and radio buttons
Introduced this feature by https://github.com/kaliber5/ember-bootstrap/pull/127
2016-08-20 22:51:21 +02:00
jelhan
5613dfdd43 add button for copying poll link
closes #95
2016-08-20 22:02:53 +02:00
jelhan
c4a1b99c75 enforce wizzard start at first step 2016-08-18 01:09:58 +02:00
jelhan
3d251bc9fb provide status bar to indicate steps of poll creation wizard
part of #76
2016-08-14 22:57:10 +02:00
jelhan
6653da8ee4 Fix: CSP style-src: 'unsafe-inline' violation
Could get rid of `style-src: 'unsafe-inline'` after
https://github.com/mkoryak/floatThead/pull/321 has been merged
and made it's way in a new release.

Part of #90
2016-08-13 18:46:46 +02:00
jelhan
2a75db5304 Update to chartjs 2.x
enhancements:
* responsive charts
* native support for stacked bars
* CSP: script-src: unsafe-inline is not needed anymore #90
2016-08-12 23:09:43 +02:00
jelhan
b5b00dcf99 Fix deprecation: EMBER-APPLICATION.APP-INSTANCE-CONTAINER
http://emberjs.com/deprecations/v2.x/#toc_ember-applicationinstance-container
2016-08-12 23:09:43 +02:00
jelhan
8b319ed1a9 this.resource is deprecated; this.route is doing the same 2016-08-12 23:09:43 +02:00
jelhan
1400b71417 updates ember, ember data and ember data model fragments and fixes some container deprecation 2016-08-12 23:09:37 +02:00
jelhan
c8fbc62d8c deprecations in ember data 1.13 2016-08-12 13:33:03 +02:00
jelhan
3cb05ca5b3 adds test that user is notified if poll can't be saved
related to #78
2016-08-12 13:00:18 +02:00
jelhan
1396957297 Fix: use a new record per user
was broken by 66b89456d3
2016-08-12 00:43:05 +02:00
jelhan
92c2c353d8 Fix view deprecation by refactoring to component 2016-08-11 23:37:14 +02:00
jelhan
26b3dab102 update ember-suave and fix some coding style 2016-08-11 22:47:17 +02:00
jelhan
66b89456d3 Fix: feedback if participation can't be saved
adresses #78
2016-08-04 22:24:53 +02:00
jelhan
d8a014b677 Label (day) validation state should reflect validation states of all related input fields (times) 2016-08-01 21:35:06 +02:00
jelhan
376821db98 improve wrong time form validation message 2016-07-28 09:56:24 +02:00
jelhan
6158a0afe0 Only show "copy and paste times of first day to all other days" if there
is more than one day
2016-07-28 01:22:09 +02:00
jelhan
c23ade384a Improve text 2016-07-28 01:19:28 +02:00
jelhan
145a4ea96a Fix: reuse existing arrayproxy since otherwise it's not connected to model anymore 2016-07-27 23:06:54 +02:00
jelhan
0627d409b5 Fix: adblock plus blocks every element having class .share-link 2016-07-27 21:49:12 +02:00
jelhan
5521b29409 Fix: feedback icons are only supported for input elements by bootstrap 2016-07-27 15:17:10 +02:00
jelhan
724a995372 Fixes: invalid times should not be adopted on other days 2016-07-05 11:26:03 +02:00
jelhan
baa09bc19f translations: missing space 2016-07-04 14:42:18 +02:00
jelhan
a28923ead2 refactor to use groupBy computed macro of ember-array-computed-macros instead of ember-group-by 2016-07-04 14:39:00 +02:00
jelhan
0c0dc44195 reactored to use array computed macros for cleaner code 2016-07-03 19:49:36 +02:00
jelhan
aafe5966e3 Fix: Confusing unique validation error messages for options 2016-07-03 16:50:42 +02:00
jelhan
3c187886c1 remove unnecessary complexity 2016-06-27 13:04:20 +02:00
jelhan
2e128e3c3c Fix: confusing validation present error for answer selection in poll participation 2016-06-27 12:53:05 +02:00
jelhan
0460fe56b1 Merge branch 'master' of github.com:jelhan/croodle 2016-06-27 12:52:30 +02:00
jelhan
9a21eb126a Fix: submit if no day is selected 2016-06-27 12:49:40 +02:00
rugk
92d1534dd8 Improve German translation 2016-06-21 19:49:52 +02:00