Commit graph

92 commits

Author SHA1 Message Date
Jeldrik Hanschke
6571a07ca5
show validation error if time input is partially filled (#279) 2019-11-02 16:51:47 +01:00
Jeldrik Hanschke
b421d19601
refactor step management and do not allow going forward with invalid state (#263)
Also removes an observer that causes a "You modified 'disabled' twice in a single render" and executes the logic in the next run loop to prevent that error. That's not ideal but it's not time for a major refactoring of that part.
2019-10-29 08:42:00 +01:00
Jeldrik Hanschke
67caaad803
upgrade Ember CLI to 3.13 and Ember Source + Ember Data to 3.12 (#264)
* upgrade Ember CLI to 3.13 and Ember Source + Ember Data to 3.12

Ember Source upgrade to 3.13 is blocked by Ember CP Validations,
which does not support Ember Source 3.13 yet.

Ember Data upgrade to 3.13 is blocked by Ember Data Model Fragments,
which does not support Ember Data 3.13 yet.

Also removes autofocus mixin and inlines the code as mixins are
considered an antipattern in latest Ember versions.

Removes some left overs in `"resolutions"` key. But that shouldn't have a real impact.
2019-10-29 08:02:50 +01:00
jelhan
7688d468e4
improve form buttons (#211)
* Adds a loading spinner to form buttons as long as submission is pending.
* Does some refactoring of form navigation buttons.
* Updates expected bundle size.
2019-06-12 09:07:48 +02:00
sappor0
c23ba1f6fb Using bootstrap 4 and related UI refresh (#205)
Changes at a glance:

- Switch from BS3 to BS4
- Polishing of some UI elements (low-hanging fruit for UX)
- Mobile-friendly layout.
2019-06-07 11:22:13 +02:00
jelhan
08f2a81ac1
Drop jQuery (#196)
Drops ember-radio-buttons addon and uses a plain input element instead. ember-radio-buttons doesn't seem to be maintained anymore and required jQuery. Also plain input element seems to be much easier to maintain.

Replaces ember-ajax by ember-fetch as ember-ajax is build on top of jQuery.ajax().

This reduces the bundle size by 25 KB (JavaScript) after gzip. Updating the size limit accordingly.
2019-05-22 12:29:29 +02:00
jelhan
bb160cc503
refactor participants table (#164)
- Drops floatthead and additional scrollbar
- Makes header and first column sticky
- Refactors code for readability

Sticky header is only working in Firefox. Chrome and Edge does not support `position: sticky` for `<thead>`. Haven't tested Safari.
2019-04-20 23:29:59 +02:00
Jeldrik Hanschke
06a92b947f refactor: replace bootstrap-datepicker by ember-power-calendar
Also renders two linked calendars if there is enough space.

Closes #143
2019-01-20 17:08:16 +01:00
Jeldrik Hanschke
96f1990542 fix: label should reflect validation state of all times of a day 2019-01-03 00:46:36 +01:00
Jeldrik Hanschke
af4fe70f72 refactor: drop ember-simple-select 2019-01-02 23:48:36 +01:00
Jeldrik Hanschke
174b6d493c refactor create/settings to avoid observer
This also fix a bug if user creates more than one croodle without reloading window
in between. In that case a data fragment is reused which throws.

It's also the first step in dropping {{simple-select}} which is very outdated.
2018-12-31 12:09:17 +01:00
Jeldrik Hanschke
bcd4bc7ac6 upgrade to ember 3.4 2018-12-31 10:17:03 +01:00
Jeldrik Hanschke
71d303174e refactor: drop ember-array-computed-macros 2018-12-30 01:04:33 +01:00
Jeldrik Hanschke
11265cb82d deps: upgrade ember to 2.18 2018-12-29 20:23:19 +01:00
Jeldrik Hanschke
6592102837 deps: upgrade ember-cp-validations to 3.x 2018-12-29 20:23:19 +01:00
jelhan
9c4bd9e669
upgrade ember-bootstrap and ember-bootstrap-cp-validations to latest versions (#146)
Ember Bootstrap has changed a lot since the very outdated pre 1.0 release
which was used here. Changes are mostly about using composable components
and closure actions.

Also replaces PhantomJS with Chrome in CI cause PhantomJS is also very
outdated and causing test failure not related to any real world issues.
Ember CLI has replaced PhantomJS with Chrome in v2.15.1, which is the
upfollowing minor release to the version currently used.
2018-10-28 22:54:14 +01:00
jelhan
64a9dea5e7 refactor dates handling (#137)
* Remove dates ArrayProxy.
* Use moment template helpers.
* Pass timezone and locale directly to moment template helper to avoid issues.
2017-08-11 16:39:36 +02:00
jelhan
e99a2f13b8 Fix: chart options are overriden by poll options
Bug introduced by 1df562b352.
2017-08-03 16:44:38 +02:00
jelhan
1df562b352 refactor {{poll-evaluation-chart}} and {{poll-evaluation-participants-table}} interfaces to make them less complex 2017-08-01 09:48:48 +02:00
jelhan
632c36eb12 updates dependencies and fixes property modified twice in a single render deprecations 2017-08-01 09:48:48 +02:00
jelhan
d76783c9cf refactor form navigation to use a component 2016-09-23 19:39:31 +02:00
jelhan
d5705b2c3b Fix: participation table header should not overflow container
Was introduced by this breaking change in jquery.floatThead:
3973eb523a
2016-08-30 11:10:05 +02:00
jelhan
545f3b0664 autofocus first form element
currently not working for date selection (calendar) since this one did not
support keyboard navigation

part of #94
2016-08-26 00:10:22 +02:00
jelhan
e735587c93 update floatThead and drop CSP unsafe-inline requirement
Closes #90
2016-08-23 11:43:58 +02:00
jelhan
d8db29ecd9 adds back button to create wizard
Part of #76
2016-08-21 00:38:44 +02:00
jelhan
6653da8ee4 Fix: CSP style-src: 'unsafe-inline' violation
Could get rid of `style-src: 'unsafe-inline'` after
https://github.com/mkoryak/floatThead/pull/321 has been merged
and made it's way in a new release.

Part of #90
2016-08-13 18:46:46 +02:00
jelhan
2a75db5304 Update to chartjs 2.x
enhancements:
* responsive charts
* native support for stacked bars
* CSP: script-src: unsafe-inline is not needed anymore #90
2016-08-12 23:09:43 +02:00
jelhan
92c2c353d8 Fix view deprecation by refactoring to component 2016-08-11 23:37:14 +02:00
jelhan
26b3dab102 update ember-suave and fix some coding style 2016-08-11 22:47:17 +02:00
jelhan
d8a014b677 Label (day) validation state should reflect validation states of all related input fields (times) 2016-08-01 21:35:06 +02:00
jelhan
145a4ea96a Fix: reuse existing arrayproxy since otherwise it's not connected to model anymore 2016-07-27 23:06:54 +02:00
jelhan
724a995372 Fixes: invalid times should not be adopted on other days 2016-07-05 11:26:03 +02:00
jelhan
a28923ead2 refactor to use groupBy computed macro of ember-array-computed-macros instead of ember-group-by 2016-07-04 14:39:00 +02:00
jelhan
0c0dc44195 reactored to use array computed macros for cleaner code 2016-07-03 19:49:36 +02:00
jelhan
3c187886c1 remove unnecessary complexity 2016-06-27 13:04:20 +02:00
jelhan
9a21eb126a Fix: submit if no day is selected 2016-06-27 12:49:40 +02:00
jelhan
7b2a9672f4 Fixes: Date in poll evaluation summary does not observe locale changes. 2016-06-20 20:48:48 +02:00
jelhan
a7e141828d Fixes #89 2016-06-20 19:28:10 +02:00
jelhan
308b8fb367 preserve existing times if day selection is changed 2016-06-13 11:14:42 +02:00
jelhan
86a233fb02 Fix: do not delete a date if it's the last one for this day
Details: https://github.com/jelhan/croodle/issues/99#issuecomment-225140574
2016-06-10 20:59:02 +02:00
jelhan
bcccffacec Fix: adopt times of first day if there aren't any times on first day 2016-06-09 12:27:51 +02:00
jelhan
2c11fe41bf perserve validation state in create/options-datetime by avoiding rerender 2016-06-08 13:56:06 +02:00
jelhan
72513bf893 remove ember-form-master-2000 2016-06-06 01:19:24 +02:00
jelhan
5b8d59c00b rewrite create/options-datetime with ember-bootstrap
ToDo left:
refactor `datetimes` property of `create-options-datetime` component to
not cause whole list to be updated. This is not only a performance issue
but also UX: e.g. validation state is lost when another item is added.
2016-06-06 01:19:24 +02:00
jelhan
3f84279b6a create/options (findADate) label validation state reflect all options 2016-06-06 01:19:24 +02:00
jelhan
32f9c3e633 use ember-bootstrap in create/index, create/meta, create/settings 2016-06-06 01:19:23 +02:00
jelhan
c8847d4814 Fix: duplicates in options arrays
Occurs if another day is added to an option array already having times
2016-05-21 18:37:23 +02:00
jelhan
c9ef942c79 Fixes #84 2016-05-21 17:17:08 +02:00
jelhan
fba32d3590 Fix deprecation: using @each as a leaf node in a dependent key
http://emberjs.com/deprecations/v1.x/#toc_using-code-each-code-as-a-leaf-node-in-a-dependent-key

Also fixes coding style:
* use Ember.computed instead of {}.property()
* use Ember.observer instead of {}.observes()
2016-05-20 23:43:05 +02:00
jelhan
70f7879ee7 Fixes #55 2016-05-20 21:49:29 +02:00