Commit graph

45 commits

Author SHA1 Message Date
Jeldrik Hanschke
58144bbf62
address deprecated arguments in Ember Bootstrap (#468) 2020-10-31 08:17:32 +01:00
Jeldrik Hanschke
4fd4333c3c
simplify autofocus implementation using a modifier (#465) 2020-10-27 22:34:08 +01:00
Jeldrik Hanschke
77afc0d9fa
remove implicit this usage in templates (#352)
This refactors references to values in templates from `{{foo}}` to either `{{this.foo}}` if it's a property of backing JavaScript class or `{{@foo}}` if it's passed in on invocation.

You could find more details on this change in Ember docs:
- [required `this` in templates](https://guides.emberjs.com/release/upgrading/current-edition/templates/#toc_required-this-in-templates)
- [named arguments](https://guides.emberjs.com/release/upgrading/current-edition/templates/#toc_named-arguments)

While doing this I noticed that `<PollEvaluationSummaryOption>` component could be easily refactored to a template-only component. Done it as part of this pull request even so it's technically not related.
2020-01-18 12:17:06 +01:00
Jeldrik Hanschke
18ba1b6bbc
convert component invocation to angle brackets (#339) 2020-01-08 15:58:10 +01:00
Jeldrik Hanschke
3d48c221a0
use specialised button for saving (#331)
Adds a <SaveButton> component that renders a save button similar to
<NextButton> but using a special icon that helps to distinguish both.

Also removes the block mode for <NextButton> component and some arguments
that aren't needed anymore.

Closes #294
2020-01-02 17:13:36 +01:00
Jeldrik Hanschke
d9b1bf7b5a
Improve test coverage for validation on participation form (#308)
* add tests that participation form is validated
* assert that first invalid form element is focused on invalid submission attempt
2019-11-20 14:52:23 +01:00
Jeldrik Hanschke
91e3ccfb4b
scroll invalid radio groups into focus on submission (#305) 2019-11-15 23:24:54 +01:00
Jeldrik Hanschke
eb421142c0
radio inputs used on participation form should have validation feedback classes (#304) 2019-11-15 23:08:59 +01:00
renovate[bot]
2dc5c22409 Update dependency ember-bootstrap to v3 (#255) 2019-11-14 21:18:52 +01:00
Jeldrik Hanschke
4e6d046ec7
add abort button to retry save modal and several other fixes for it (#291)
Croodle shows a modal if saving a participation fails. The modal allows
a user to retry the save attempt. While it was always possible to close
the button by clicking on backdrop or using escape key, a button to do so
was missing. A user may not know about the user ways and may see reloading
the page as only possibilty to close the modal if he doesn't want to retry
again.

This adds the missing abort button and fixes some smaller bugs including:

- The modal was missing a title.
- If the modal was closed once it wasn't reopened on another failed saving
  attemp unless the user has visit another page in between.
- Several arguments were passed to <BsModal> that weren't existing at all.
2019-11-10 10:25:51 +01:00
Jeldrik Hanschke
c55beabcfe
scroll first invalid input into view port on invalid submission (#282) 2019-11-02 21:57:59 +01:00
jelhan
7688d468e4
improve form buttons (#211)
* Adds a loading spinner to form buttons as long as submission is pending.
* Does some refactoring of form navigation buttons.
* Updates expected bundle size.
2019-06-12 09:07:48 +02:00
sappor0
c23ba1f6fb Using bootstrap 4 and related UI refresh (#205)
Changes at a glance:

- Switch from BS3 to BS4
- Polishing of some UI elements (low-hanging fruit for UX)
- Mobile-friendly layout.
2019-06-07 11:22:13 +02:00
jelhan
08f2a81ac1
Drop jQuery (#196)
Drops ember-radio-buttons addon and uses a plain input element instead. ember-radio-buttons doesn't seem to be maintained anymore and required jQuery. Also plain input element seems to be much easier to maintain.

Replaces ember-ajax by ember-fetch as ember-ajax is build on top of jQuery.ajax().

This reduces the bundle size by 25 KB (JavaScript) after gzip. Updating the size limit accordingly.
2019-05-22 12:29:29 +02:00
jelhan
bb160cc503
refactor participants table (#164)
- Drops floatthead and additional scrollbar
- Makes header and first column sticky
- Refactors code for readability

Sticky header is only working in Firefox. Chrome and Edge does not support `position: sticky` for `<thead>`. Haven't tested Safari.
2019-04-20 23:29:59 +02:00
Jeldrik Hanschke
bcd4bc7ac6 upgrade to ember 3.4 2018-12-31 10:17:03 +01:00
jelhan
9c4bd9e669
upgrade ember-bootstrap and ember-bootstrap-cp-validations to latest versions (#146)
Ember Bootstrap has changed a lot since the very outdated pre 1.0 release
which was used here. Changes are mostly about using composable components
and closure actions.

Also replaces PhantomJS with Chrome in CI cause PhantomJS is also very
outdated and causing test failure not related to any real world issues.
Ember CLI has replaced PhantomJS with Chrome in v2.15.1, which is the
upfollowing minor release to the version currently used.
2018-10-28 22:54:14 +01:00
jelhan
64a9dea5e7 refactor dates handling (#137)
* Remove dates ArrayProxy.
* Use moment template helpers.
* Pass timezone and locale directly to moment template helper to avoid issues.
2017-08-11 16:39:36 +02:00
jelhan
1df562b352 refactor {{poll-evaluation-chart}} and {{poll-evaluation-participants-table}} interfaces to make them less complex 2017-08-01 09:48:48 +02:00
jelhan
d76783c9cf refactor form navigation to use a component 2016-09-23 19:39:31 +02:00
jelhan
545f3b0664 autofocus first form element
currently not working for date selection (calendar) since this one did not
support keyboard navigation

part of #94
2016-08-26 00:10:22 +02:00
jelhan
17d4a3feda save button should have suitable text 2016-08-20 23:35:54 +02:00
jelhan
afb06e4f12 Fix: novalidate option of {{bs-form}} should be true (and not string 'true')
This had been fixed in ember-bootstrap 0.9.0
2016-08-20 22:59:50 +02:00
jelhan
8d9278a9ee show validation immediately after change for select and radio buttons
Introduced this feature by https://github.com/kaliber5/ember-bootstrap/pull/127
2016-08-20 22:51:21 +02:00
jelhan
3cb05ca5b3 adds test that user is notified if poll can't be saved
related to #78
2016-08-12 13:00:18 +02:00
jelhan
92c2c353d8 Fix view deprecation by refactoring to component 2016-08-11 23:37:14 +02:00
jelhan
66b89456d3 Fix: feedback if participation can't be saved
adresses #78
2016-08-04 22:24:53 +02:00
jelhan
5521b29409 Fix: feedback icons are only supported for input elements by bootstrap 2016-07-27 15:17:10 +02:00
jelhan
01bd5a6466 remove formatted-date helper (not in use anymore) 2016-06-21 01:44:50 +02:00
jelhan
0592eff1f0 ember-bootstrap for poll/participation 2016-06-06 01:19:23 +02:00
jelhan
7c56c5c5e0 Fix: missing translations 2016-05-21 20:05:13 +02:00
jelhan
08e9f68197 remove polls isDateTime attribute 2016-05-18 13:18:36 -07:00
jelhan
aa6483c4d1 Fixes #81 2016-03-20 15:31:24 +01:00
jelhan
277d51e650 poll evaluation as stacked bar chart 2016-03-17 13:32:53 +01:00
jelhan
4b33ddf48e Support polls findADate with mixed dates and datetimes 2016-02-13 18:37:33 +01:00
jelhan
8e2c188cf6 update properties on locale change 2015-11-24 00:53:03 +01:00
jelhan
2f9ad47edf Fix bind-attr deprecation
http://emberjs.com/deprecations/v1.x/#toc_bind-attr
2015-11-22 14:28:32 +01:00
jelhan
2f4c6f7d07 Fix: DEPRECATION: Using the '{{#each item in model}}' form of the {{#each}} helper
is deprecated. Please use the block param form instead ('{{#each model as |item|}}').
See http://emberjs.com/guides/deprecations/#toc_code-in-code-syntax-for-code-each-code
for more details.
2015-11-22 14:17:37 +01:00
jelhan
4c597352ad update ember-from-master-2000 2015-11-20 23:02:35 +01:00
jelhan
3706e88620 normal defaults and override them if necessary 2015-11-15 19:49:59 +01:00
jelhan
de359576f5 fix: bootstrap layout 2015-11-15 17:03:55 +01:00
jelhan
8ecb082ce3 move 'horizontal' class to config in initializer 2015-11-15 16:50:19 +01:00
jelhan
01f9b6e61f extract participation form from participants table and make it a bootstrap form
started replacing ember-easy-form-extensions by ember-form-master-2000
and ember-validations by ember-cp-validations

using ember-form-master-2000 in old 0.2 release cause newer releases does not work with ember 0.12
should move to ember 2.x as soon as possible
therefore ember-easy-form-extensions has to be dropped and ember-i18n been updated

part of #76
2015-11-12 15:52:14 +01:00
jelhan
475245d04f evaluation summary as component 2015-11-03 12:57:41 +01:00
jelhan
858b75e543 routable tabs in poll view for participation and evaluation 2015-11-02 23:02:59 +01:00