Commit graph

219 commits

Author SHA1 Message Date
Jeldrik Hanschke
748b17e0ea
answers could be derived from answerType (#704)
* answers could be derived from answerType

* improve readability of API test data

* update API tests for removed answers property
2023-10-23 17:33:25 +02:00
Jeldrik Hanschke
3a23719127
do not rely on Array prototype extensions (#692)
* Array.any() relies on prototype extensions

* remove remaining usage of array prototype extensions
2023-10-18 14:52:57 +02:00
renovate[bot]
8118aabb1f
Update dependency ember-cli-clipboard to v1 (#637)
* Update dependency ember-cli-clipboard to v1

* update for changed public API

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jeldrik Hanschke <admin@jhanschke.de>
2023-10-17 11:49:21 +02:00
Jeldrik Hanschke
fa9f91288c
fix RouterService.transitionTo not bound to this instance (#680) 2023-10-16 14:10:29 +02:00
renovate[bot]
831ed35136
Update dependency ember-cli-page-object to v2 (#673)
* Update dependency ember-cli-page-object to v2

* upgrade to new APIs

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jeldrik Hanschke <admin@jhanschke.de>
2023-10-16 00:07:22 +02:00
Jeldrik Hanschke
0f94d81ad4
fix ember-cli-page-object deprecations (#674)
* fix ember-cli-page-object deprecations

* make linter happy
2023-10-15 23:26:18 +02:00
Jeldrik Hanschke
97605ec7d7
fix some deprecations (#659)
* get deprecation workflow up to date

* fix routing.transition-methods deprecation

* fix this-property-fallback deprecation

* fix implicit-injections deprecation

* argument-less-helper-paren-less-invocation

* remove unmaintained ember-transition-helper which triggers deprecated-run-loop-and-computed-dot-access deprecation

* reset to only log but not throw on errors to not block other development

* reset double quote to single quote changes in templates and fix Prettier config

* fix JS linting

* ugprade ember-template-lint to fix parser
2023-10-15 21:50:28 +02:00
Jeldrik Hanschke
4c0936af35
remove unused named outlet (#658) 2023-10-15 21:12:09 +02:00
Jeldrik Hanschke
02058ab756
upgrade to Ember 3.28 blueprints (#647) 2023-10-15 20:37:03 +02:00
Jeldrik Hanschke
82ec8b59f7
refactor to tracked properties (#621) 2023-10-15 17:32:11 +02:00
Jeldrik Hanschke
857f2baa16
simplify form validation and drop ember-cp-validations (#631)
* replace ember-cp-validations with custom validation logic for poll creation

* refactor poll participation to not use ember-cp-validations

* drop ember-cp-validations from create.settings route

* remove unused leftovers from ember-cp-validations

* fix potential leak

* assertion thrown in CI tests (Firefox) indicate that listener is cleaned up automatically

* synchronize translations
2023-10-15 15:27:02 +02:00
Jeldrik Hanschke
77f8f5804f
drop computed properties in poll participation controller if possible (#630) 2023-10-15 12:06:27 +02:00
Jeldrik Hanschke
128cb37c1e
upgrade to Ember Bootstrap v4 (#623) 2023-09-30 11:15:50 +02:00
Jeldrik Hanschke
2094f0d91b
colocate component templates (#620) 2023-09-22 22:22:48 +02:00
Jeldrik Hanschke
2a4b1f8b73
Use native browser APIs and Luxon instead of Moment (#612) 2023-09-21 12:30:14 +02:00
Jeldrik Hanschke
5143a6ae88
remove chart in poll evaluation (#610) 2023-08-19 20:57:57 +02:00
renovate[bot]
e84fb40f49
Update dependency ember-page-title to v6 (#437)
* Update dependency ember-page-title to v6

* ember-page-title no longer requires ember-cli-head

ember-page-title no longer requires the usage of ember-cli-head.
Please remove {{head-layout}} from your application's application.hbs route template

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Jeldrik Hanschke <admin@jhanschke.de>
2021-01-16 13:11:19 +01:00
Jeldrik Hanschke
386a4c1f83
can not set type attribute using angle bracket invocation (#507) 2021-01-16 12:54:12 +01:00
Jeldrik Hanschke
58144bbf62
address deprecated arguments in Ember Bootstrap (#468) 2020-10-31 08:17:32 +01:00
Jeldrik Hanschke
4fd4333c3c
simplify autofocus implementation using a modifier (#465) 2020-10-27 22:34:08 +01:00
Jeldrik Hanschke
7da65be276
refactor deprecated {{title}} to {{page-title}} (#464) 2020-10-27 22:20:35 +01:00
Jeldrik Hanschke
8a62662e6e
migrate from ember-i18n to ember-intl (#358)
* mark string as html safe before passing to translation instead of bypassing HTML escape using {{{unsafe}}} syntax
* replace ember-i18n with ember-intl
2020-01-30 00:23:12 +01:00
Jeldrik Hanschke
33886f3c4e
fix link to GitHub used in translated text (#355) 2020-01-21 22:16:21 +01:00
Jeldrik Hanschke
77afc0d9fa
remove implicit this usage in templates (#352)
This refactors references to values in templates from `{{foo}}` to either `{{this.foo}}` if it's a property of backing JavaScript class or `{{@foo}}` if it's passed in on invocation.

You could find more details on this change in Ember docs:
- [required `this` in templates](https://guides.emberjs.com/release/upgrading/current-edition/templates/#toc_required-this-in-templates)
- [named arguments](https://guides.emberjs.com/release/upgrading/current-edition/templates/#toc_named-arguments)

While doing this I noticed that `<PollEvaluationSummaryOption>` component could be easily refactored to a template-only component. Done it as part of this pull request even so it's technically not related.
2020-01-18 12:17:06 +01:00
Jeldrik Hanschke
c9482786c1
refactor to native ECMAScript classes (#344)
Replaces Ember's old object model by native ECMAScript classes. Mostly automated with ember-native-class-codemod.
2020-01-18 10:13:50 +01:00
Jeldrik Hanschke
9983f76189
refactor form steps implementation (#345) 2020-01-13 17:13:23 +01:00
Jeldrik Hanschke
18ba1b6bbc
convert component invocation to angle brackets (#339) 2020-01-08 15:58:10 +01:00
Jeldrik Hanschke
7e784434b6
Upgrade Ember to 3.15 and other deps (#338) 2020-01-08 15:57:46 +01:00
Jeldrik Hanschke
3d48c221a0
use specialised button for saving (#331)
Adds a <SaveButton> component that renders a save button similar to
<NextButton> but using a special icon that helps to distinguish both.

Also removes the block mode for <NextButton> component and some arguments
that aren't needed anymore.

Closes #294
2020-01-02 17:13:36 +01:00
Jeldrik Hanschke
d9b1bf7b5a
Improve test coverage for validation on participation form (#308)
* add tests that participation form is validated
* assert that first invalid form element is focused on invalid submission attempt
2019-11-20 14:52:23 +01:00
Jeldrik Hanschke
91e3ccfb4b
scroll invalid radio groups into focus on submission (#305) 2019-11-15 23:24:54 +01:00
Jeldrik Hanschke
eb421142c0
radio inputs used on participation form should have validation feedback classes (#304) 2019-11-15 23:08:59 +01:00
renovate[bot]
2dc5c22409 Update dependency ember-bootstrap to v3 (#255) 2019-11-14 21:18:52 +01:00
Jeldrik Hanschke
0da3dc8b02
next/save button should get focus before back button (#298) 2019-11-12 21:56:47 +01:00
Jeldrik Hanschke
d8c316cd75
validation become visible should not alter position of calendar (#296) 2019-11-11 22:34:16 +01:00
Jeldrik Hanschke
cf6d59bf84
readd colors indicating answer to participant table (#289) 2019-11-10 17:44:44 +01:00
Jeldrik Hanschke
4e6d046ec7
add abort button to retry save modal and several other fixes for it (#291)
Croodle shows a modal if saving a participation fails. The modal allows
a user to retry the save attempt. While it was always possible to close
the button by clicking on backdrop or using escape key, a button to do so
was missing. A user may not know about the user ways and may see reloading
the page as only possibilty to close the modal if he doesn't want to retry
again.

This adds the missing abort button and fixes some smaller bugs including:

- The modal was missing a title.
- If the modal was closed once it wasn't reopened on another failed saving
  attemp unless the user has visit another page in between.
- Several arguments were passed to <BsModal> that weren't existing at all.
2019-11-10 10:25:51 +01:00
Jeldrik Hanschke
bde9254fd7
remove partially filled validation error on clear (#283) 2019-11-03 19:19:55 +01:00
Jeldrik Hanschke
c55beabcfe
scroll first invalid input into view port on invalid submission (#282) 2019-11-02 21:57:59 +01:00
Jeldrik Hanschke
6571a07ca5
show validation error if time input is partially filled (#279) 2019-11-02 16:51:47 +01:00
renovate[bot]
7e189ab83c Update dependency ember-power-calendar to ^0.14.0 (#239) 2019-10-29 10:43:06 +01:00
Jeldrik Hanschke
b421d19601
refactor step management and do not allow going forward with invalid state (#263)
Also removes an observer that causes a "You modified 'disabled' twice in a single render" and executes the logic in the next run loop to prevent that error. That's not ideal but it's not time for a major refactoring of that part.
2019-10-29 08:42:00 +01:00
Jeldrik Hanschke
6e26789b8b improve positioning of validation feedback
Also refactors the template to use Octance features.
2019-10-28 13:18:53 +01:00
Jeldrik Hanschke
6b0bb68919
fix invisible validation error message for date selection (#257) 2019-10-20 12:43:27 +02:00
jelhan
07da863520
fix typo resulting in missing translation strings (#224) 2019-06-15 00:04:32 +02:00
jelhan
7688d468e4
improve form buttons (#211)
* Adds a loading spinner to form buttons as long as submission is pending.
* Does some refactoring of form navigation buttons.
* Updates expected bundle size.
2019-06-12 09:07:48 +02:00
sappor0
c23ba1f6fb Using bootstrap 4 and related UI refresh (#205)
Changes at a glance:

- Switch from BS3 to BS4
- Polishing of some UI elements (low-hanging fruit for UX)
- Mobile-friendly layout.
2019-06-07 11:22:13 +02:00
jelhan
08f2a81ac1
Drop jQuery (#196)
Drops ember-radio-buttons addon and uses a plain input element instead. ember-radio-buttons doesn't seem to be maintained anymore and required jQuery. Also plain input element seems to be much easier to maintain.

Replaces ember-ajax by ember-fetch as ember-ajax is build on top of jQuery.ajax().

This reduces the bundle size by 25 KB (JavaScript) after gzip. Updating the size limit accordingly.
2019-05-22 12:29:29 +02:00
jelhan
17cfb4ab6d
Meaningful error pages (#177)
Adds meaningful error pages if
- poll does not exist
- encryption key is wrong.
2019-04-23 17:37:42 +02:00
jelhan
bb160cc503
refactor participants table (#164)
- Drops floatthead and additional scrollbar
- Makes header and first column sticky
- Refactors code for readability

Sticky header is only working in Firefox. Chrome and Edge does not support `position: sticky` for `<thead>`. Haven't tested Safari.
2019-04-20 23:29:59 +02:00