Commit graph

72 commits

Author SHA1 Message Date
Jeldrik Hanschke
7e784434b6
Upgrade Ember to 3.15 and other deps (#338) 2020-01-08 15:57:46 +01:00
Jeldrik Hanschke
3d48c221a0
use specialised button for saving (#331)
Adds a <SaveButton> component that renders a save button similar to
<NextButton> but using a special icon that helps to distinguish both.

Also removes the block mode for <NextButton> component and some arguments
that aren't needed anymore.

Closes #294
2020-01-02 17:13:36 +01:00
Jeldrik Hanschke
0da3dc8b02
next/save button should get focus before back button (#298) 2019-11-12 21:56:47 +01:00
Jeldrik Hanschke
d8c316cd75
validation become visible should not alter position of calendar (#296) 2019-11-11 22:34:16 +01:00
Jeldrik Hanschke
cf6d59bf84
readd colors indicating answer to participant table (#289) 2019-11-10 17:44:44 +01:00
Jeldrik Hanschke
bde9254fd7
remove partially filled validation error on clear (#283) 2019-11-03 19:19:55 +01:00
Jeldrik Hanschke
c55beabcfe
scroll first invalid input into view port on invalid submission (#282) 2019-11-02 21:57:59 +01:00
Jeldrik Hanschke
6571a07ca5
show validation error if time input is partially filled (#279) 2019-11-02 16:51:47 +01:00
renovate[bot]
7e189ab83c Update dependency ember-power-calendar to ^0.14.0 (#239) 2019-10-29 10:43:06 +01:00
Jeldrik Hanschke
b421d19601
refactor step management and do not allow going forward with invalid state (#263)
Also removes an observer that causes a "You modified 'disabled' twice in a single render" and executes the logic in the next run loop to prevent that error. That's not ideal but it's not time for a major refactoring of that part.
2019-10-29 08:42:00 +01:00
Jeldrik Hanschke
6e26789b8b improve positioning of validation feedback
Also refactors the template to use Octance features.
2019-10-28 13:18:53 +01:00
Jeldrik Hanschke
6b0bb68919
fix invisible validation error message for date selection (#257) 2019-10-20 12:43:27 +02:00
jelhan
7688d468e4
improve form buttons (#211)
* Adds a loading spinner to form buttons as long as submission is pending.
* Does some refactoring of form navigation buttons.
* Updates expected bundle size.
2019-06-12 09:07:48 +02:00
sappor0
c23ba1f6fb Using bootstrap 4 and related UI refresh (#205)
Changes at a glance:

- Switch from BS3 to BS4
- Polishing of some UI elements (low-hanging fruit for UX)
- Mobile-friendly layout.
2019-06-07 11:22:13 +02:00
jelhan
bb160cc503
refactor participants table (#164)
- Drops floatthead and additional scrollbar
- Makes header and first column sticky
- Refactors code for readability

Sticky header is only working in Firefox. Chrome and Edge does not support `position: sticky` for `<thead>`. Haven't tested Safari.
2019-04-20 23:29:59 +02:00
Jeldrik Hanschke
06a92b947f refactor: replace bootstrap-datepicker by ember-power-calendar
Also renders two linked calendars if there is enough space.

Closes #143
2019-01-20 17:08:16 +01:00
Jeldrik Hanschke
96f1990542 fix: label should reflect validation state of all times of a day 2019-01-03 00:46:36 +01:00
Jeldrik Hanschke
3330151156 refactor: drop unnecessary dynamic component usage 2018-12-31 12:09:23 +01:00
Jeldrik Hanschke
174b6d493c refactor create/settings to avoid observer
This also fix a bug if user creates more than one croodle without reloading window
in between. In that case a data fragment is reused which throws.

It's also the first step in dropping {{simple-select}} which is very outdated.
2018-12-31 12:09:17 +01:00
Jeldrik Hanschke
bcd4bc7ac6 upgrade to ember 3.4 2018-12-31 10:17:03 +01:00
Jeldrik Hanschke
b7e63ed83b refactor: replace ember-object-at-helper by ember-composable-helpers 2018-12-30 10:06:49 +01:00
jelhan
9c4bd9e669
upgrade ember-bootstrap and ember-bootstrap-cp-validations to latest versions (#146)
Ember Bootstrap has changed a lot since the very outdated pre 1.0 release
which was used here. Changes are mostly about using composable components
and closure actions.

Also replaces PhantomJS with Chrome in CI cause PhantomJS is also very
outdated and causing test failure not related to any real world issues.
Ember CLI has replaced PhantomJS with Chrome in v2.15.1, which is the
upfollowing minor release to the version currently used.
2018-10-28 22:54:14 +01:00
jelhan
64a9dea5e7 refactor dates handling (#137)
* Remove dates ArrayProxy.
* Use moment template helpers.
* Pass timezone and locale directly to moment template helper to avoid issues.
2017-08-11 16:39:36 +02:00
jelhan
e99a2f13b8 Fix: chart options are overriden by poll options
Bug introduced by 1df562b352.
2017-08-03 16:44:38 +02:00
jelhan
1df562b352 refactor {{poll-evaluation-chart}} and {{poll-evaluation-participants-table}} interfaces to make them less complex 2017-08-01 09:48:48 +02:00
jelhan
d76783c9cf refactor form navigation to use a component 2016-09-23 19:39:31 +02:00
jelhan
17b7f81dea UX: next and back buttons in create wizzard in xs and sm 2016-09-18 20:44:22 +02:00
jelhan
545f3b0664 autofocus first form element
currently not working for date selection (calendar) since this one did not
support keyboard navigation

part of #94
2016-08-26 00:10:22 +02:00
jelhan
d8db29ecd9 adds back button to create wizard
Part of #76
2016-08-21 00:38:44 +02:00
jelhan
9a33e08ac4 browser should not mess around with our validation logic 2016-08-20 23:41:27 +02:00
jelhan
17d4a3feda save button should have suitable text 2016-08-20 23:35:54 +02:00
jelhan
2a75db5304 Update to chartjs 2.x
enhancements:
* responsive charts
* native support for stacked bars
* CSP: script-src: unsafe-inline is not needed anymore #90
2016-08-12 23:09:43 +02:00
jelhan
92c2c353d8 Fix view deprecation by refactoring to component 2016-08-11 23:37:14 +02:00
jelhan
d8a014b677 Label (day) validation state should reflect validation states of all related input fields (times) 2016-08-01 21:35:06 +02:00
jelhan
6158a0afe0 Only show "copy and paste times of first day to all other days" if there
is more than one day
2016-07-28 01:22:09 +02:00
jelhan
724a995372 Fixes: invalid times should not be adopted on other days 2016-07-05 11:26:03 +02:00
jelhan
7b2a9672f4 Fixes: Date in poll evaluation summary does not observe locale changes. 2016-06-20 20:48:48 +02:00
jelhan
9d9121c04e all outstanding PRs for ember-bootstrap got merged 2016-06-14 13:53:22 +02:00
jelhan
341fafaaec placeholder for time input type as a shim if browser does not support it
otherwise placeholder is ignored due to spec

http://caniuse.com/#feat=input-datetime
2016-06-10 11:12:49 +02:00
jelhan
327d6cd737 object-at helper as addon 2016-06-08 18:42:26 +02:00
jelhan
2c11fe41bf perserve validation state in create/options-datetime by avoiding rerender 2016-06-08 13:56:06 +02:00
jelhan
72513bf893 remove ember-form-master-2000 2016-06-06 01:19:24 +02:00
jelhan
5b8d59c00b rewrite create/options-datetime with ember-bootstrap
ToDo left:
refactor `datetimes` property of `create-options-datetime` component to
not cause whole list to be updated. This is not only a performance issue
but also UX: e.g. validation state is lost when another item is added.
2016-06-06 01:19:24 +02:00
jelhan
4a31aaa616 use ember-bootstrap in create/options
ToDo:
Label validation state should not be bound to validation state of first element (option)
but to validation state of all elements. If any element has an error label validation state
should be error. Only if all elements are fine, label validation state should also be fine.
2016-06-06 01:19:24 +02:00
jelhan
c9ef942c79 Fixes #84 2016-05-21 17:17:08 +02:00
jelhan
70f7879ee7 Fixes #55 2016-05-20 21:49:29 +02:00
jelhan
08e9f68197 remove polls isDateTime attribute 2016-05-18 13:18:36 -07:00
jelhan
f3426b2a7d support creating polls with only one option
There might be use cases and it simplifies validation a lot.

Also fixes this missing translation message mentioned in #84:
> /create/options-datetime: There isn't any validation error shown when validation fails due to not enough times.
2016-04-15 11:21:26 +02:00
jelhan
277d51e650 poll evaluation as stacked bar chart 2016-03-17 13:32:53 +01:00
jelhan
8ede03b604 Fix: Date was not shown if there were multiple best options 2016-02-22 23:42:01 +01:00