Commit graph

2 commits

Author SHA1 Message Date
Jeldrik Hanschke
77afc0d9fa
remove implicit this usage in templates (#352)
This refactors references to values in templates from `{{foo}}` to either `{{this.foo}}` if it's a property of backing JavaScript class or `{{@foo}}` if it's passed in on invocation.

You could find more details on this change in Ember docs:
- [required `this` in templates](https://guides.emberjs.com/release/upgrading/current-edition/templates/#toc_required-this-in-templates)
- [named arguments](https://guides.emberjs.com/release/upgrading/current-edition/templates/#toc_named-arguments)

While doing this I noticed that `<PollEvaluationSummaryOption>` component could be easily refactored to a template-only component. Done it as part of this pull request even so it's technically not related.
2020-01-18 12:17:06 +01:00
Jeldrik Hanschke
3091f9ac5e deps: upgrade ember-page-title
Current page title is put before generic one, e.g. "Create a poll | Croodle"
instead of "Croodle | Create a poll". This was an upstream change with
could reasoning. Have a look here:
https://github.com/adopted-ember-addons/ember-page-title/releases/tag/5.0.0

Version 4.0.0 required the `{{head-layout}}` component in application's
template:
https://github.com/adopted-ember-addons/ember-page-title/releases/tag/4.0.0
2018-12-31 14:12:21 +01:00