Commit graph

126 commits

Author SHA1 Message Date
Jeldrik Hanschke
27b36e2005
refactor create/settings controller to component (#820) 2023-12-19 19:48:54 +01:00
Jeldrik Hanschke
f25625f40d
rafactor create/options-datetime controller to component (#819) 2023-12-19 19:28:04 +01:00
Jeldrik Hanschke
f9f0c365e8
refactor create/options controller to component (#815) 2023-12-17 23:10:57 +01:00
Jeldrik Hanschke
e3935e521f
refactor create/meta controller to component (#814) 2023-12-17 22:31:14 +01:00
Jeldrik Hanschke
4950e327ed
refactor /create/index controller to component (#760) 2023-12-16 23:22:43 +01:00
Jeldrik Hanschke
de9d58b434
use Prettier for Glimmer templates (#731) 2023-11-05 20:57:52 +01:00
Jeldrik Hanschke
147f5dace4
Report copy success via tooltip at copy button (#730)
* refactor copy button to show success with tooltip

* remove ember-cli-flash

* update expected bundlesize
2023-11-05 17:06:27 +01:00
Jeldrik Hanschke
88a51964f1
report poll saving errors using a modal (#729) 2023-11-05 12:19:47 +01:00
Jeldrik Hanschke
bf87f6f305
converts poll/participation and poll/evaluation controllers to TypeScript (#724) 2023-11-04 17:21:35 +01:00
Jeldrik Hanschke
76586f165d
Introduce typed templates with Glint (#714) 2023-11-04 14:54:30 +01:00
Jeldrik Hanschke
f0cff27e99
Convert to TypeScript (#713)
* setup typescript

* covert to TypeScript
2023-10-29 19:16:33 +01:00
Jeldrik Hanschke
2d5914ff63
replace ember data with native classes (#708) 2023-10-28 19:15:06 +02:00
Jeldrik Hanschke
1072953cd4
refactor poll creation to not rely on Ember Data model (#710) 2023-10-28 17:50:17 +02:00
Jeldrik Hanschke
748b17e0ea
answers could be derived from answerType (#704)
* answers could be derived from answerType

* improve readability of API test data

* update API tests for removed answers property
2023-10-23 17:33:25 +02:00
Jeldrik Hanschke
3a23719127
do not rely on Array prototype extensions (#692)
* Array.any() relies on prototype extensions

* remove remaining usage of array prototype extensions
2023-10-18 14:52:57 +02:00
renovate[bot]
d2a24daf66
Update dependency ember-template-lint to v5 (#655)
* Update dependency ember-template-lint to v5

* fix new linting violations

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jeldrik Hanschke <admin@jhanschke.de>
2023-10-17 10:46:08 +02:00
renovate[bot]
98ff62af80
Update dependency prettier to v3 (#668)
* Update dependency prettier to v3

* upgrade eslint-plugin-prettier and run prettier on all files

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jeldrik Hanschke <admin@jhanschke.de>
2023-10-17 10:44:45 +02:00
Jeldrik Hanschke
2e9d8581b1
WIP: Upgrade to Ember v4.4 (#679)
* first try

* upgrade ember-intl to v5

* simplify code and avoid deprecated / removed APIs

* fix RouterService.transitionTo not bound to this instance

* fix modified after consumption error

* fix lint
2023-10-16 14:26:00 +02:00
Jeldrik Hanschke
0f94d81ad4
fix ember-cli-page-object deprecations (#674)
* fix ember-cli-page-object deprecations

* make linter happy
2023-10-15 23:26:18 +02:00
Jeldrik Hanschke
97605ec7d7
fix some deprecations (#659)
* get deprecation workflow up to date

* fix routing.transition-methods deprecation

* fix this-property-fallback deprecation

* fix implicit-injections deprecation

* argument-less-helper-paren-less-invocation

* remove unmaintained ember-transition-helper which triggers deprecated-run-loop-and-computed-dot-access deprecation

* reset to only log but not throw on errors to not block other development

* reset double quote to single quote changes in templates and fix Prettier config

* fix JS linting

* ugprade ember-template-lint to fix parser
2023-10-15 21:50:28 +02:00
Jeldrik Hanschke
02058ab756
upgrade to Ember 3.28 blueprints (#647) 2023-10-15 20:37:03 +02:00
Jeldrik Hanschke
650910fcfc
refactor remaining components to @glimmer/component (#639) 2023-10-15 19:11:08 +02:00
Jeldrik Hanschke
82ec8b59f7
refactor to tracked properties (#621) 2023-10-15 17:32:11 +02:00
Jeldrik Hanschke
857f2baa16
simplify form validation and drop ember-cp-validations (#631)
* replace ember-cp-validations with custom validation logic for poll creation

* refactor poll participation to not use ember-cp-validations

* drop ember-cp-validations from create.settings route

* remove unused leftovers from ember-cp-validations

* fix potential leak

* assertion thrown in CI tests (Firefox) indicate that listener is cleaned up automatically

* synchronize translations
2023-10-15 15:27:02 +02:00
Jeldrik Hanschke
e984b9012d
fix displaying dates in participants table for polls having dates with times (#625)
* fix: participants table not listing times in header
* fix: participants table shows days in wrong timezone
2023-10-01 16:21:49 +02:00
Jeldrik Hanschke
128cb37c1e
upgrade to Ember Bootstrap v4 (#623) 2023-09-30 11:15:50 +02:00
Jeldrik Hanschke
2094f0d91b
colocate component templates (#620) 2023-09-22 22:22:48 +02:00
Jeldrik Hanschke
2a4b1f8b73
Use native browser APIs and Luxon instead of Moment (#612) 2023-09-21 12:30:14 +02:00
Jeldrik Hanschke
5143a6ae88
remove chart in poll evaluation (#610) 2023-08-19 20:57:57 +02:00
Jeldrik Hanschke
4fd4333c3c
simplify autofocus implementation using a modifier (#465) 2020-10-27 22:34:08 +01:00
Jeldrik Hanschke
8a62662e6e
migrate from ember-i18n to ember-intl (#358)
* mark string as html safe before passing to translation instead of bypassing HTML escape using {{{unsafe}}} syntax
* replace ember-i18n with ember-intl
2020-01-30 00:23:12 +01:00
Jeldrik Hanschke
77afc0d9fa
remove implicit this usage in templates (#352)
This refactors references to values in templates from `{{foo}}` to either `{{this.foo}}` if it's a property of backing JavaScript class or `{{@foo}}` if it's passed in on invocation.

You could find more details on this change in Ember docs:
- [required `this` in templates](https://guides.emberjs.com/release/upgrading/current-edition/templates/#toc_required-this-in-templates)
- [named arguments](https://guides.emberjs.com/release/upgrading/current-edition/templates/#toc_named-arguments)

While doing this I noticed that `<PollEvaluationSummaryOption>` component could be easily refactored to a template-only component. Done it as part of this pull request even so it's technically not related.
2020-01-18 12:17:06 +01:00
Jeldrik Hanschke
c9482786c1
refactor to native ECMAScript classes (#344)
Replaces Ember's old object model by native ECMAScript classes. Mostly automated with ember-native-class-codemod.
2020-01-18 10:13:50 +01:00
Jeldrik Hanschke
bde9254fd7
remove partially filled validation error on clear (#283) 2019-11-03 19:19:55 +01:00
Jeldrik Hanschke
6571a07ca5
show validation error if time input is partially filled (#279) 2019-11-02 16:51:47 +01:00
Jeldrik Hanschke
b421d19601
refactor step management and do not allow going forward with invalid state (#263)
Also removes an observer that causes a "You modified 'disabled' twice in a single render" and executes the logic in the next run loop to prevent that error. That's not ideal but it's not time for a major refactoring of that part.
2019-10-29 08:42:00 +01:00
Jeldrik Hanschke
67caaad803
upgrade Ember CLI to 3.13 and Ember Source + Ember Data to 3.12 (#264)
* upgrade Ember CLI to 3.13 and Ember Source + Ember Data to 3.12

Ember Source upgrade to 3.13 is blocked by Ember CP Validations,
which does not support Ember Source 3.13 yet.

Ember Data upgrade to 3.13 is blocked by Ember Data Model Fragments,
which does not support Ember Data 3.13 yet.

Also removes autofocus mixin and inlines the code as mixins are
considered an antipattern in latest Ember versions.

Removes some left overs in `"resolutions"` key. But that shouldn't have a real impact.
2019-10-29 08:02:50 +01:00
jelhan
7688d468e4
improve form buttons (#211)
* Adds a loading spinner to form buttons as long as submission is pending.
* Does some refactoring of form navigation buttons.
* Updates expected bundle size.
2019-06-12 09:07:48 +02:00
sappor0
c23ba1f6fb Using bootstrap 4 and related UI refresh (#205)
Changes at a glance:

- Switch from BS3 to BS4
- Polishing of some UI elements (low-hanging fruit for UX)
- Mobile-friendly layout.
2019-06-07 11:22:13 +02:00
jelhan
08f2a81ac1
Drop jQuery (#196)
Drops ember-radio-buttons addon and uses a plain input element instead. ember-radio-buttons doesn't seem to be maintained anymore and required jQuery. Also plain input element seems to be much easier to maintain.

Replaces ember-ajax by ember-fetch as ember-ajax is build on top of jQuery.ajax().

This reduces the bundle size by 25 KB (JavaScript) after gzip. Updating the size limit accordingly.
2019-05-22 12:29:29 +02:00
jelhan
bb160cc503
refactor participants table (#164)
- Drops floatthead and additional scrollbar
- Makes header and first column sticky
- Refactors code for readability

Sticky header is only working in Firefox. Chrome and Edge does not support `position: sticky` for `<thead>`. Haven't tested Safari.
2019-04-20 23:29:59 +02:00
Jeldrik Hanschke
06a92b947f refactor: replace bootstrap-datepicker by ember-power-calendar
Also renders two linked calendars if there is enough space.

Closes #143
2019-01-20 17:08:16 +01:00
Jeldrik Hanschke
96f1990542 fix: label should reflect validation state of all times of a day 2019-01-03 00:46:36 +01:00
Jeldrik Hanschke
af4fe70f72 refactor: drop ember-simple-select 2019-01-02 23:48:36 +01:00
Jeldrik Hanschke
174b6d493c refactor create/settings to avoid observer
This also fix a bug if user creates more than one croodle without reloading window
in between. In that case a data fragment is reused which throws.

It's also the first step in dropping {{simple-select}} which is very outdated.
2018-12-31 12:09:17 +01:00
Jeldrik Hanschke
bcd4bc7ac6 upgrade to ember 3.4 2018-12-31 10:17:03 +01:00
Jeldrik Hanschke
71d303174e refactor: drop ember-array-computed-macros 2018-12-30 01:04:33 +01:00
Jeldrik Hanschke
11265cb82d deps: upgrade ember to 2.18 2018-12-29 20:23:19 +01:00
Jeldrik Hanschke
6592102837 deps: upgrade ember-cp-validations to 3.x 2018-12-29 20:23:19 +01:00
jelhan
9c4bd9e669
upgrade ember-bootstrap and ember-bootstrap-cp-validations to latest versions (#146)
Ember Bootstrap has changed a lot since the very outdated pre 1.0 release
which was used here. Changes are mostly about using composable components
and closure actions.

Also replaces PhantomJS with Chrome in CI cause PhantomJS is also very
outdated and causing test failure not related to any real world issues.
Ember CLI has replaced PhantomJS with Chrome in v2.15.1, which is the
upfollowing minor release to the version currently used.
2018-10-28 22:54:14 +01:00