Commit graph

230 commits

Author SHA1 Message Date
jelhan
3cb05ca5b3 adds test that user is notified if poll can't be saved
related to #78
2016-08-12 13:00:18 +02:00
jelhan
1396957297 Fix: use a new record per user
was broken by 66b89456d3
2016-08-12 00:43:05 +02:00
jelhan
26b3dab102 update ember-suave and fix some coding style 2016-08-11 22:47:17 +02:00
jelhan
66b89456d3 Fix: feedback if participation can't be saved
adresses #78
2016-08-04 22:24:53 +02:00
jelhan
aa9e0f132b Fix test: Acceptance | create a poll: create a poll and using back button (find a date) 2016-07-28 01:08:43 +02:00
jelhan
bac6c4e72d Fix test after version in package.json has been corrected 2016-07-27 23:17:51 +02:00
jelhan
4bdea08b60 Fix test broken by 0627d409b5 2016-07-27 23:12:35 +02:00
jelhan
724a995372 Fixes: invalid times should not be adopted on other days 2016-07-05 11:26:03 +02:00
jelhan
a28923ead2 refactor to use groupBy computed macro of ember-array-computed-macros instead of ember-group-by 2016-07-04 14:39:00 +02:00
jelhan
01bd5a6466 remove formatted-date helper (not in use anymore) 2016-06-21 01:44:50 +02:00
jelhan
7b2a9672f4 Fixes: Date in poll evaluation summary does not observe locale changes. 2016-06-20 20:48:48 +02:00
jelhan
a7e141828d Fixes #89 2016-06-20 19:28:10 +02:00
jelhan
308b8fb367 preserve existing times if day selection is changed 2016-06-13 11:14:42 +02:00
jelhan
86a233fb02 Fix: do not delete a date if it's the last one for this day
Details: https://github.com/jelhan/croodle/issues/99#issuecomment-225140574
2016-06-10 20:59:02 +02:00
jelhan
acc05d68c5 remove webshim polyfills
UX in browser which does not support time input type should be okay know by
validation messages and placeholder. Wasn't even used anymore in latest release.

Affects #90 but does not resolve 'unsafe-inline' requirement cause to
ember-bootstrap (https://github.com/kaliber5/ember-bootstrap/pull/98#discussion_r66586065).
2016-06-10 11:35:55 +02:00
jelhan
bcccffacec Fix: adopt times of first day if there aren't any times on first day 2016-06-09 12:27:51 +02:00
jelhan
327d6cd737 object-at helper as addon 2016-06-08 18:42:26 +02:00
jelhan
2c11fe41bf perserve validation state in create/options-datetime by avoiding rerender 2016-06-08 13:56:06 +02:00
jelhan
72513bf893 remove ember-form-master-2000 2016-06-06 01:19:24 +02:00
jelhan
5b8d59c00b rewrite create/options-datetime with ember-bootstrap
ToDo left:
refactor `datetimes` property of `create-options-datetime` component to
not cause whole list to be updated. This is not only a performance issue
but also UX: e.g. validation state is lost when another item is added.
2016-06-06 01:19:24 +02:00
jelhan
4a31aaa616 use ember-bootstrap in create/options
ToDo:
Label validation state should not be bound to validation state of first element (option)
but to validation state of all elements. If any element has an error label validation state
should be error. Only if all elements are fine, label validation state should also be fine.
2016-06-06 01:19:24 +02:00
jelhan
0592eff1f0 ember-bootstrap for poll/participation 2016-06-06 01:19:23 +02:00
jelhan
c8847d4814 Fix: duplicates in options arrays
Occurs if another day is added to an option array already having times
2016-05-21 18:37:23 +02:00
jelhan
c9ef942c79 Fixes #84 2016-05-21 17:17:08 +02:00
jelhan
70f7879ee7 Fixes #55 2016-05-20 21:49:29 +02:00
jelhan
08e9f68197 remove polls isDateTime attribute 2016-05-18 13:18:36 -07:00
jelhan
f3426b2a7d support creating polls with only one option
There might be use cases and it simplifies validation a lot.

Also fixes this missing translation message mentioned in #84:
> /create/options-datetime: There isn't any validation error shown when validation fails due to not enough times.
2016-04-15 11:21:26 +02:00
jelhan
8a32f1f5c8 Closes #87. 2016-04-11 00:37:46 +02:00
jelhan
e5c5198601 Fixes #85 2016-04-09 01:52:54 +02:00
jelhan
194f00b7d6 Rewritten (some) acceptance tests with ember-cli-page-objects 2016-04-08 21:48:22 +02:00
jelhan
c240b712b6 Fixes #88
Also fixes test which was false positive and added some other tests.
2016-03-21 22:06:08 +01:00
jelhan
0ab6ff374c Fix: String could be less than 10 characters which causes test to fail
Math.random() could return 0, 0.5, 0.51 which isn't enough input for a 10 characters string.
2016-03-21 13:05:23 +01:00
jelhan
aa6483c4d1 Fixes #81 2016-03-20 15:31:24 +01:00
jelhan
6f6395e430 Fixes #82 2016-03-18 20:26:41 +01:00
jelhan
9a658ab76d allow alpha / beta / rc releases 2016-03-18 13:15:32 +01:00
jelhan
277d51e650 poll evaluation as stacked bar chart 2016-03-17 13:32:53 +01:00
jelhan
014c717d34 sort options after times where set 2016-02-18 12:06:54 +01:00
jelhan
b921632465 reimplement adopt times of first day (was: copy first line) 2016-02-16 04:02:59 +01:00
jelhan
e906fbd09d fix failing test due to input polyfill 2016-02-16 04:01:17 +01:00
jelhan
0fd12adf65 move time selection to separate page again 2016-02-16 02:26:27 +01:00
jelhan
4b33ddf48e Support polls findADate with mixed dates and datetimes 2016-02-13 18:37:33 +01:00
jelhan
0e4fd114cb some improvement on validations 2016-02-09 01:16:18 +01:00
jelhan
c53593d2cf options must be unique 2016-02-08 23:46:30 +01:00
jelhan
4bcb45d0bb revert change in dynamic segment (under_score to camelCase) since
poll id was not set as part of url afterwards;
add tests to not let this happen again
2016-01-31 15:30:31 +01:00
jelhan
40a7fdf606 fix validators and there tests
tests had wrong results before
2016-01-31 14:54:23 +01:00
jelhan
a60c84e8d2 Fix failing tests in browser (including PhatomJS) which doesn't support input[type="time"]
due to webshim polyfill
2016-01-29 12:54:54 +01:00
jelhan
fefa4edfe4 wrong description 2016-01-29 11:47:19 +01:00
jelhan
8f08e57d1d fix some more code style issues 2016-01-28 23:48:14 +01:00
jelhan
13ddf1194b Merge branch 'master' into rewrite-create-options 2016-01-28 12:36:21 +01:00
jelhan
682e6a658e fix coding style errors
> helpers/poll-has-users.js should pass jscs.
> requireSemicolons: Missing semicolon after statement at helpers/poll-has-users.js
is incostitent with JSHint which complains about this semicolon

other ones should be fixed by rewrite of create/options
2016-01-28 12:34:56 +01:00
jelhan
c5e66436b7 Merge branch 'master' into rewrite-create-options 2016-01-28 11:27:58 +01:00
jelhan
95c5142ad1 some more JSCS fixes 2016-01-28 11:27:00 +01:00
jelhan
4937d9b27b create-options-datetime is reimplemented; add / delete of options also works
main work seems to be done
2016-01-22 00:19:46 +01:00
jelhan
33d641623a Merge branch 'master' into rewrite-create-options 2016-01-20 04:23:41 +01:00
jelhan
123655ad37 some more code style errors 2016-01-20 03:52:06 +01:00
jelhan
32106b7e79 Merge branch 'master' into rewrite-create-options 2016-01-20 03:19:28 +01:00
jelhan
e9a6f9ff41 fix some more JSCS code style errors 2016-01-20 03:19:10 +01:00
jelhan
ec3999bbc9 input datetimes
ToDo:
* integration test for options-create-datetime
* acceptance tests for poll find a date with times
* some translations
* ...
2016-01-20 02:52:21 +01:00
jelhan
9cfcb6d27a Merge branch 'master' into rewrite-create-options 2016-01-19 05:55:37 +01:00
jelhan
6ba930661e add JSCS code style test and fix errors 2016-01-19 05:46:52 +01:00
jelhan
ce2a8c8e1f done most things except date with times
also validation messages are missing
2016-01-19 04:56:51 +01:00
jelhan
70a3a6a4ab fix: test that version is included as HTML meta tag 2015-12-08 11:39:30 +01:00
jelhan
c13d55ec01 test that version is included as HTML meta tag 2015-12-08 11:27:41 +01:00
jelhan
52a20050f2 upgrade ember-cli to 1.13.13 2015-12-07 20:24:22 +01:00
jelhan
c5a42ce9d8 readd test for missing translations 2015-11-26 13:33:40 +01:00
jelhan
b209fe1d82 Fix failing tests caused by different moment locale in test vs application 2015-11-24 01:37:37 +01:00
jelhan
05ae26cc80 add tests for validation create/options-datetime 2015-11-22 19:16:27 +01:00
jelhan
ae52eb8be1 refactor validator time and allow i18n of error messages for valid-collection 2015-11-22 19:11:32 +01:00
jelhan
8afe43f270 Fix unit tests controller:create
needs a run loop and dates must not be created before visit cause
moment locale isn't that before application route is reached
2015-11-20 23:33:20 +01:00
jelhan
f8fa5aa47b Fix tests: controller:create; needs run loop 2015-11-20 23:15:38 +01:00
jelhan
4c597352ad update ember-from-master-2000 2015-11-20 23:02:35 +01:00
jelhan
e1bb2da6d1 fix jshint 2015-11-20 11:31:40 +01:00
jelhan
c1dfa16eed update ember-i18n 2015-11-20 02:18:19 +01:00
jelhan
9bf19de533 this shouldn't be in repo 2015-11-20 02:03:14 +01:00
jelhan
149cf7fe8b update ember-cli to 1.13.8 2015-11-20 00:17:15 +01:00
jelhan
f67381c6b9 remove ember-easy-form-extensions, finally 2015-11-19 21:51:49 +01:00
jelhan
f5f3f525f7 make validator reusable 2015-11-18 17:49:01 +01:00
jelhan
6f6cc8b61d rewritten create/index and create/meta with ember-cp-validations and ember-form-master-2000 2015-11-16 14:28:00 +01:00
jelhan
ca387848ed create/options input fields for make a poll with add / delete buttons
also rewritten using ember-cp-validations and ember-form-master-2000
2015-11-16 13:09:13 +01:00
jelhan
bd58f2865b was removed by c3ee937936 2015-11-15 19:24:47 +01:00
jelhan
01f9b6e61f extract participation form from participants table and make it a bootstrap form
started replacing ember-easy-form-extensions by ember-form-master-2000
and ember-validations by ember-cp-validations

using ember-form-master-2000 in old 0.2 release cause newer releases does not work with ember 0.12
should move to ember 2.x as soon as possible
therefore ember-easy-form-extensions has to be dropped and ember-i18n been updated

part of #76
2015-11-12 15:52:14 +01:00
jelhan
8b74eb7d86 fix side effect in unit tests for languages by only parsing a copy of imported languages object to ember-i18n 2015-11-04 12:49:28 +01:00
jelhan
b37a831d93 remove failing test which should ensure that all translations have same keys
ember-i18n pluralization seems to add another key to languages object (without pluralization)
not sure why this modified languages object is retrieved by test
810aa7f04b (pluralization)
2015-11-03 13:04:30 +01:00
jelhan
475245d04f evaluation summary as component 2015-11-03 12:57:41 +01:00
jelhan
858b75e543 routable tabs in poll view for participation and evaluation 2015-11-02 23:02:59 +01:00
jelhan
176d45b317 use a service for encryption key handling 2015-10-25 19:38:14 +01:00
jelhan
6275fb54ec Merge branch 'model-fragments' of github.com:jelhan/croodle into model-fragments
Conflicts:
	app/templates/poll.hbs
	tests/acceptance/view-poll-test.js

There isn't any legacy support yet; so integration tests for legacy support will fail.
2015-10-25 16:01:55 +01:00
jelhan
cb2634e10a array transform is replaced by model fragments 2015-10-25 15:32:42 +01:00
jelhan
243ed3b12a model fragments for user selections (currently same as answers) 2015-10-25 15:32:42 +01:00
jelhan
d020f67e90 model fragments for options 2015-10-25 15:29:47 +01:00
jelhan
dd1a8436e0 model fragments for answers 2015-10-25 15:29:47 +01:00
jelhan
3c26bd7001 data of integration tests isn't cleared, so we can't be sure that there aren't more users by runs before 2015-10-25 15:26:27 +01:00
jelhan
128cb35162 another legacy test 2015-10-19 11:19:01 +02:00
jelhan
d09aa843bb introduce test helper for poll participation and extend some tests with it 2015-10-18 14:04:04 +02:00
jelhan
dec12d81a7 move legacy support to api 2015-10-17 15:44:27 +02:00
jelhan
cd7737d65b add legacy support for v0.3.0 2015-10-16 17:41:24 +02:00
jelhan
1b02c262d2 even more test helpers 2015-10-16 11:21:06 +02:00
jelhan
187155811c make more use of test helpers in acceptance tests 2015-10-14 20:36:47 +02:00
jelhan
bf1d18b2c0 array transform is replaced by model fragments 2015-10-13 21:46:49 +02:00
jelhan
9004eb6027 model fragments for user selections (currently same as answers) 2015-10-13 21:30:26 +02:00
jelhan
505319e464 model fragments for options 2015-10-13 11:29:51 +02:00
jelhan
3d4cf3f408 model fragments for answers 2015-10-12 13:40:29 +02:00
jelhan
0ae62f31f1 added test for translation object 2015-08-21 12:29:09 +02:00
jelhan
5a240e79e1 added some (ugly) tests for evaluation 2015-08-21 12:10:02 +02:00
jelhan
398453c1e4 do encryption / decryption in serializer
before it was done as computed properties of model

accessing encryption key in serializer is done via global application var.
this should be removed in long-term
2015-08-19 22:00:01 +02:00
jelhan
c9ed3e8a06 readd integration test 2015-08-19 11:29:30 +02:00
jelhan
7cef56c2d1 some more tests about showing correct dates and times and handeling
different time zones
2015-08-01 23:54:07 +02:00
jelhan
d26cd827c1 Fix: moment.localeData().longDateFormat() changed
More details: http://stackoverflow.com/questions/25179377/date-format-momentjs-extract-date-and-time-separately-using-locale-language/31761415#31761415
2015-08-01 13:51:04 +02:00
jelhan
1f955d4e93 update ember-moment 2015-08-01 11:41:41 +02:00
jelhan
dfdbf98042 rewrite create a poll-tests as acceptance tests using pretender 2015-08-01 11:03:00 +02:00
jelhan
1f39409f66 avoid globale namespace 2015-07-27 20:56:52 +02:00
jelhan
f9eaa10ee1 refactor "participate in poll"-tests as acceptance tests using pretender instead of dummy data 2015-07-27 20:28:00 +02:00
jelhan
c7440fd0b9 pretender... 2015-07-22 11:52:22 +02:00
jelhan
5181d45fc0 added some tests 2015-07-19 20:55:20 +02:00
jelhan
67cc41973f Ember.ObjectController is deprecated since ember 1.11
Ember.ObjectController was proxying model properties to controller. Ember.Controller which should be used is not.
Therefore we have to define if it's a property of controller or model.

Also added two more tests:
* anonymous participation
* do not force an answer for all options
2015-07-01 16:21:18 +02:00
jelhan
90a7e6dbe1 Fix test if it is run multiple times (more than one user is present) 2015-06-20 18:42:28 +02:00
jelhan
5cce0a236d Fix: freetext answer where broken by caba42a853
added test to not let it happen again
2015-06-20 18:33:51 +02:00
jelhan
3929460595 restructering tests 2015-06-11 10:53:22 +02:00
jelhan
04561b66d0 fix tests after update 2015-04-02 20:09:07 +02:00
jelhan
9b73dd8863 update to ember-cli 0.2.2 and ember 1.11.0 2015-04-02 20:01:30 +02:00
jelhan
57726c2996 update ember-cli to 1.2.1 and ember to 1.10
update to ember 1.10 causes several issues due to HTMLBars; some are allready fixed but some not:
* current used version of ember-easyForm is not compatible with ember 1.10
* tests aren't working
2015-04-02 12:56:55 +02:00
jelhan
bc4ebadf1b fix: add a user to a default poll test 2015-01-24 18:31:21 +01:00
jelhan
7d5fd78d9a fix: PHP Deprecated: Function split() is deprecated 2015-01-24 17:14:57 +01:00
jelhan
226220cd78 need absolute path if locationType 'hash' as stated in docs 2015-01-24 15:36:04 +01:00
jelhan
29e43c26e8 dummy polls for testing and development
test: add a user to a default poll

default poll url
http://localhost:4200/#/poll/defaultpoll?encryptionKey=0123456789abcdefghijklmnopqrstuvwxyzABC
2015-01-24 14:50:56 +01:00
jelhan
139b6b7088 upgrade ember-cli to 0.1.7
Tests doesn't run to due an error with relative api uri. This doesn't affect development or production environment.
2015-01-18 18:06:47 +01:00
jelhan
7c5131320d Added more tests
should find a way to aviod repeating myself in all tests...
2014-12-19 19:59:29 +01:00
jelhan
8af5a9df09 Integration Test for creation of a default poll 2014-11-26 13:15:05 +01:00
jelhan
7a241bd311 first steps to ember-cli 2014-10-30 21:44:22 +01:00
jelhan
b066b8806c Starting to move to Ember App Kit 2014-07-06 17:37:54 +02:00