Croodle shows a modal if saving a participation fails. The modal allows
a user to retry the save attempt. While it was always possible to close
the button by clicking on backdrop or using escape key, a button to do so
was missing. A user may not know about the user ways and may see reloading
the page as only possibilty to close the modal if he doesn't want to retry
again.
This adds the missing abort button and fixes some smaller bugs including:
- The modal was missing a title.
- If the modal was closed once it wasn't reopened on another failed saving
attemp unless the user has visit another page in between.
- Several arguments were passed to <BsModal> that weren't existing at all.
Also removes an observer that causes a "You modified 'disabled' twice in a single render" and executes the logic in the next run loop to prevent that error. That's not ideal but it's not time for a major refactoring of that part.
* upgrade Ember CLI to 3.13 and Ember Source + Ember Data to 3.12
Ember Source upgrade to 3.13 is blocked by Ember CP Validations,
which does not support Ember Source 3.13 yet.
Ember Data upgrade to 3.13 is blocked by Ember Data Model Fragments,
which does not support Ember Data 3.13 yet.
Also removes autofocus mixin and inlines the code as mixins are
considered an antipattern in latest Ember versions.
Removes some left overs in `"resolutions"` key. But that shouldn't have a real impact.
Ember Boostrap adds `.d-block` class to validation feedback in order to
make it visible for input-group in which the `.invalid-feedback` is not
a silbing of `.form-control`.
This fixes the invisble validation feedback on /create/options (poll type:
answer a question) and /create/options-datetime (poll type: find a date).
* Adds a loading spinner to form buttons as long as submission is pending.
* Does some refactoring of form navigation buttons.
* Updates expected bundle size.
* Fixed some typos/stylistic issues with the english localisation strings
* typographically correct ellipsis
* typographically correct apostrophe
* typographically correct em dash
Drops ember-radio-buttons addon and uses a plain input element instead. ember-radio-buttons doesn't seem to be maintained anymore and required jQuery. Also plain input element seems to be much easier to maintain.
Replaces ember-ajax by ember-fetch as ember-ajax is build on top of jQuery.ajax().
This reduces the bundle size by 25 KB (JavaScript) after gzip. Updating the size limit accordingly.
- Drops floatthead and additional scrollbar
- Makes header and first column sticky
- Refactors code for readability
Sticky header is only working in Firefox. Chrome and Edge does not support `position: sticky` for `<thead>`. Haven't tested Safari.
This also fix a bug if user creates more than one croodle without reloading window
in between. In that case a data fragment is reused which throws.
It's also the first step in dropping {{simple-select}} which is very outdated.
Ember Bootstrap has changed a lot since the very outdated pre 1.0 release
which was used here. Changes are mostly about using composable components
and closure actions.
Also replaces PhantomJS with Chrome in CI cause PhantomJS is also very
outdated and causing test failure not related to any real world issues.
Ember CLI has replaced PhantomJS with Chrome in v2.15.1, which is the
upfollowing minor release to the version currently used.
