From 391bd79e03ea088cee79905d619f985619735d68 Mon Sep 17 00:00:00 2001
From: muxator <a.mux@inwind.it>
Date: Wed, 29 Aug 2018 01:38:55 +0200
Subject: [PATCH] padurlsanitize: early return, no functional changes

---
 src/node/hooks/express/padurlsanitize.js | 39 ++++++++++++------------
 1 file changed, 19 insertions(+), 20 deletions(-)

diff --git a/src/node/hooks/express/padurlsanitize.js b/src/node/hooks/express/padurlsanitize.js
index a9972220..be3ffb1b 100644
--- a/src/node/hooks/express/padurlsanitize.js
+++ b/src/node/hooks/express/padurlsanitize.js
@@ -8,26 +8,25 @@ exports.expressCreateServer = function (hook_name, args, cb) {
     if(!padManager.isValidPadId(padId) || /\/$/.test(req.url))
     {
       res.status(404).send('Such a padname is forbidden');
+      return;
     }
-    else
-    {
-      padManager.sanitizePadId(padId, function(sanitizedPadId) {
-        //the pad id was sanitized, so we redirect to the sanitized version
-        if(sanitizedPadId != padId)
-        {
-          var real_url = sanitizedPadId;
-          real_url = encodeURIComponent(real_url);
-          var query = url.parse(req.url).query;
-          if ( query ) real_url += '?' + query;
-          res.header('Location', real_url);
-          res.status(302).send('You should be redirected to <a href="' + real_url + '">' + real_url + '</a>');
-        }
-        //the pad id was fine, so just render it
-        else
-        {
-          next();
-        }
-      });
-    }
+
+    padManager.sanitizePadId(padId, function(sanitizedPadId) {
+      //the pad id was sanitized, so we redirect to the sanitized version
+      if(sanitizedPadId != padId)
+      {
+        var real_url = sanitizedPadId;
+        real_url = encodeURIComponent(real_url);
+        var query = url.parse(req.url).query;
+        if ( query ) real_url += '?' + query;
+        res.header('Location', real_url);
+        res.status(302).send('You should be redirected to <a href="' + real_url + '">' + real_url + '</a>');
+      }
+      //the pad id was fine, so just render it
+      else
+      {
+        next();
+      }
+    });
   });
 }